fix: resolve 16 failing unit tests - #332
Merged
Merged
Conversation
…and English TN - Chinese ITN: prefer currency symbol ($) over ISO code (USD) by adding weight to code FST in money rule - Japanese ITN: fix big_integer FST structure to prevent 三十 being split into 3+10=310 instead of parsed as 30 - English TN: prefer "oh" over "zero" for digit 0 in non-deterministic mode by adding weight to zero path - English TN: fix whitelist test expectation for Hon. -> Honorable
Remove entries from tts.tsv that duplicate mappings in alternatives.tsv (Hon., Mr., Mrs., Ms.) or are self-duplicated Greek letters (κ, ω, α, ν, δ, Δ, Α, β, Β). This avoids non-deterministic FST behavior across platforms when the same key maps to different values in unioned files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$) over ISO code (USD) by adding weight tocodeFST in money rule, so美元maps to$instead ofUSDbig_integerFST structure to prevent三十from being split into3+10=310instead of parsed as30ohoverzerofor digit0in non-deterministic mode by adding weight penalty to zero path in cardinal ruleHon.→Honorable(capitalized)Test plan